chore(editor): view, selection-bridge, and type fixes

vue/editor/src/env.d.ts

@@ -5,13 +5,9 @@ declare global {
 }
 
 declare module 'vue' {
-  interface ComponentCustomProps {
-    [key: `data${string}`]: unknown;
-  }
+  type ComponentCustomProps = Record<`data${string}`, unknown>;
 }
 
 declare module 'vue' {
-  interface HTMLAttributes {
-    [key: `data-${string}`]: unknown;
-  }
+  type HTMLAttributes = Record<`data-${string}`, unknown>;
 }

vue/editor/src/view/inline-content/parse.ts

@@ -35,7 +35,7 @@ function marksForElement(el: HTMLElement, registry: Registry): Mark[] {
 function walk(node: Node, marks: readonly Mark[], out: InlineNode[], registry: Registry): void {
   for (const child of Array.from(node.childNodes)) {
     if (child.nodeType === Node.TEXT_NODE) {
-      const text = (child.nodeValue ?? '').replace(ZWSP, '');
+      const text = (child.nodeValue ?? '').replaceAll(ZWSP, '');
       if (text)
         out.push({ text, marks });
       continue;

vue/editor/src/view/selection/selection-bridge.ts

@@ -48,7 +48,7 @@ function indexInParent(el: Node): number {
 }
 
 function getWindow(): Window | null {
-  return typeof globalThis.window === 'undefined' ? null : globalThis.window;
+  return globalThis.window === undefined ? null : globalThis.window;
 }
 
 export function createSelectionBridge(

vue/editor/src/view/ui/EditorBubbleMenu.vue

@@ -26,7 +26,7 @@ const { floatingStyles, update } = useFloating(reference, floatingEl, {
 });
 
 function selectionRect(): DOMRect | null {
-  const selection = typeof globalThis.window === 'undefined' ? null : globalThis.getSelection();
+  const selection = globalThis.window === undefined ? null : globalThis.getSelection();
   if (!selection || selection.rangeCount === 0)
     return null;
 

vue/editor/src/view/ui/EditorSlashMenu.vue

@@ -33,11 +33,11 @@ const { floatingStyles, update } = useFloating(reference, floatingEl, {
 });
 
 function escapeRegExp(value: string): string {
-  return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+  return value.replaceAll(/[.*+?^${}()|[\]\\]/g, '\\$&');
 }
 
 function caretRect(): DOMRect | null {
-  const selection = typeof globalThis.window === 'undefined' ? null : globalThis.getSelection();
+  const selection = globalThis.window === undefined ? null : globalThis.getSelection();
   if (!selection || selection.rangeCount === 0)
     return null;